Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Topology): remove all but one use of autoImplicit #14298

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jun 30, 2024

And remove superfluous open's in Order/ExtendFrom.


The remaining use is scoped to a single declaration in MetricSpace, something to do with instance synthesis.

Open in Gitpod

And remove superfluous open's in Order/ExtendFrom.
@grunweg grunweg added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jun 30, 2024
Copy link

PR summary 51c1ca8cec

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 30, 2024
And remove superfluous open's in Order/ExtendFrom.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology): remove all but one use of autoImplicit [Merged by Bors] - chore(Topology): remove all but one use of autoImplicit Jun 30, 2024
@mathlib-bors mathlib-bors bot closed this Jun 30, 2024
@mathlib-bors mathlib-bors bot deleted the MR-autoImplicit-topology branch June 30, 2024 22:32
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
And remove superfluous open's in Order/ExtendFrom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants