Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(SetTheory): remove use of autoImplicit #14299

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(SetTheory): remove use of autoImplicit #14299

wants to merge 2 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jun 30, 2024

Open in Gitpod

@grunweg grunweg added awaiting-review t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jun 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

PR summary 883682fac3

Import changes

No significant changes to the import graph

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

eric-wieser
eric-wieser approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 30, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 1, 2024

Thank you for the quick review!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
@grunweg
chore(SetTheory): remove use of autoImplicit (#14299)
29d8482
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
@grunweg
chore(SetTheory): remove use of autoImplicit (#14299)
a261710
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(SetTheory): remove use of autoImplicit [Merged by Bors] - chore(SetTheory): remove use of autoImplicit Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the MR-autoImplicit-settheory branch July 1, 2024 10:38
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
@grunweg @dagurtomas
chore(SetTheory): remove use of autoImplicit (#14299)
de1b32e
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grunweg @eric-wieser @leanprover-community-mathlib4-bot