-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: the one-line-align linter #14322
Conversation
PR summary 6833d4867bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Co-authored-by: Eric Wieser <[email protected]>
…y/mathlib4 into adomani/oneLineAlign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good (two trivial comments); thanks for writing it.
I think this linter can be added as long as the aligns still exist (and be removed with them). I don't have a strong opinion on this point - let's see what the broader opinion is.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by grunweg. |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Comments from Michael Co-authored-by: grunweg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
This linter makes sure that `#align` statements span a single line.
Build failed (retrying...): |
This linter makes sure that `#align` statements span a single line.
Build failed: |
Can you merge master, please? I don't see why this should fail anything... |
I think that it was conflicted with a section end in a test file. |
…y/mathlib4 into adomani/oneLineAlign
bors merge |
This linter makes sure that `#align` statements span a single line.
Pull request successfully merged into master. Build succeeded: |
This linter makes sure that
#align
statements span a single line.