Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: the one-line-align linter #14322

Closed
wants to merge 11 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 1, 2024

This linter makes sure that #align statements span a single line.


Open in Gitpod

Copy link

github-actions bot commented Jul 1, 2024

PR summary 6833d4867b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ getLinterOneLineAlign
+ oneLineAlign
+ toAlign

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good (two trivial comments); thanks for writing it.

I think this linter can be added as long as the aligns still exist (and be removed with them). I don't have a strong opinion on this point - let's see what the broader opinion is.
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

Comments from Michael

Co-authored-by: grunweg <[email protected]>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jul 10, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 10, 2024
This linter makes sure that `#align` statements span a single line.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 10, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 10, 2024
This linter makes sure that `#align` statements span a single line.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 10, 2024

Build failed:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 10, 2024
@grunweg
Copy link
Collaborator

grunweg commented Jul 11, 2024

Can you merge master, please? I don't see why this should fail anything...

@adomani
Copy link
Collaborator Author

adomani commented Jul 11, 2024

I think that it was conflicted with a section end in a test file.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 11, 2024
@mattrobball
Copy link
Collaborator

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 11, 2024
This linter makes sure that `#align` statements span a single line.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the one-line-align linter [Merged by Bors] - feat: the one-line-align linter Jul 11, 2024
@mathlib-bors mathlib-bors bot closed this Jul 11, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/oneLineAlign branch July 11, 2024 19:21
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-linter Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants