Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Topology/Stonean): remove wrong TODO from docstring #14334

Closed
wants to merge 1 commit into from

Conversation

dagurtomas
Copy link
Collaborator


This TODO was added by me at some point without thinking, because it's not true that the forgetful functor from Stonean preserves finite colimits.

Open in Gitpod

@dagurtomas dagurtomas added documentation Improvements or additions to documentation awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

PR summary f2643721a9

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

👎 Rejected by label

@riccardobrasca
Copy link
Member

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@dagurtomas
Copy link
Collaborator Author

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Topology/Stonean): remove wrong TODO from docstring [Merged by Bors] - fix(Topology/Stonean): remove wrong TODO from docstring Jul 1, 2024
@mathlib-bors mathlib-bors bot closed this Jul 1, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/StoneanTODO branch July 1, 2024 15:55
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants