Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore (Module.LinearMap.End): avoid ordered algebra imports #14335

Conversation

mattrobball
Copy link
Collaborator

We can just specialize to the results about Nat and avoid importing Algebra.Order.Ring.Nat.


Open in Gitpod

@mattrobball mattrobball added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

PR summary b4b937a06e

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Module.LinearMap.End 429 397 -32 (-7.46%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor

kim-em commented Jul 1, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 1, 2024
We can just specialize to the results about `Nat` and avoid importing `Algebra.Order.Ring.Nat`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore (Module.LinearMap.End): avoid ordered algebra imports [Merged by Bors] - chore (Module.LinearMap.End): avoid ordered algebra imports Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/disconnect_alg_ord_ring_nat_from_module_linearmap_end branch July 2, 2024 00:40
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
We can just specialize to the results about `Nat` and avoid importing `Algebra.Order.Ring.Nat`.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants