Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): zero locus of sections and characterisation of nilpotent elements #14337

Closed
wants to merge 12 commits into from

Conversation

chrisflav
Copy link
Collaborator

@chrisflav chrisflav commented Jul 1, 2024

Introduces the zero locus of a set of sections on a ringed space and characterizes nilpotent sections
over compact opens of a scheme in terms of basic opens and the zero locus.

Co-authored-by: Andrew Yang @erdOne


The Scheme.eq_of_eq_cover lemma and the IsOpenImmersion.ΓIso related things are due to Andrew.

I'd be happy to move the first two sections of the Nilpotents file somewhere else, but I did not find the canonical place.

Open in Gitpod

Copy link

github-actions bot commented Jul 1, 2024

PR summary f47d21b577

Import changes

No significant changes to the import graph


Declarations diff

+ LocallyRingedSpace.toΓSpec_preim_basicOpen_eq
+ OpenCover.ext_elem
+ Scheme.eq_zeroLocus_of_isClosed_of_isAffine
+ Scheme.isNilpotent_iff_basicOpen_eq_bot_of_isCompact
+ Scheme.toΓSpec_image_zeroLocus_eq_of_isAffine
+ Scheme.toΓSpec_preimage_zeroLocus_eq
+ Scheme.zeroLocus_eq_top_iff_subset_nilradical_of_isCompact
+ Scheme.ιOpens_appLE_isIso
+ Scheme.ιOpens_image_top
+ appLE_eq_app
+ appLE_invApp
+ basicOpen_appLE
+ basicOpen_eq_bot_of_isNilpotent
+ eqToHom_comp_homOfLE
+ eqToHom_comp_homOfLE_op
+ homOfLE_comp_eqToHom
+ homOfLE_isIso_of_eq
+ homOfLE_op_comp_eqToHom
+ homeomorph
+ image_le_image_of_le
+ image_preimage_eq_opensRange_inter
+ image_top_eq_opensRange
+ instance {X : Scheme.{u}} : Subsingleton Γ(X, ⊥)
+ isNilpotent_of_isNilpotent_cover
+ map_homOfLE
+ map_ΓIso_inv
+ opensFunctor_map_homOfLE
+ preimage_image_eq
+ toΓSpec_preimage_basicOpen_eq
+ toΓSpec_preimage_zeroLocus_eq
+ zeroLocus_def
+ zeroLocus_eq_top_iff
+ zeroLocus_iUnion₂
+ zero_of_zero_cover
+ ΓIso
+ ΓIso_hom_map
+ ΓIso_inv
++ basicOpen_pow
++ mem_zeroLocus_iff
++ zeroLocus
++ zeroLocus_empty_eq_univ
++ zeroLocus_isClosed
++ zeroLocus_singleton
- fromSpec_image_top
- toΓSpec_preim_basicOpen_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 1, 2024
@chrisflav
Copy link
Collaborator Author

I ended up moving everything somewhere else, so I removed the new file again.

@chrisflav chrisflav added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 1, 2024
@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jul 2, 2024
@chrisflav chrisflav added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 2, 2024
@chrisflav
Copy link
Collaborator Author

Thanks again for all the suggestions @erdOne! Adapted them in the latest commit.

@erdOne
Copy link
Member

erdOne commented Jul 3, 2024

Thanks!
maintainer merge
May I ask what this is for?

Copy link

github-actions bot commented Jul 3, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2024
…of nilpotent elements (#14337)

Introduces the zero locus of a set of sections on a ringed space and characterizes nilpotent sections
over compact opens of a scheme in terms of basic opens and the zero locus.

Co-authored-by: Andrew Yang @erdOne
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): zero locus of sections and characterisation of nilpotent elements [Merged by Bors] - feat(AlgebraicGeometry): zero locus of sections and characterisation of nilpotent elements Jul 3, 2024
@mathlib-bors mathlib-bors bot closed this Jul 3, 2024
@mathlib-bors mathlib-bors bot deleted the chrisflav/ag-zerolocus branch July 3, 2024 06:10
@chrisflav
Copy link
Collaborator Author

Thanks! maintainer merge May I ask what this is for?

This is towards characterizing closed immersions with affine target as quotient maps.

@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants