-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(CategoryTheory/Limits/Shapes/Pullbacks): split into multiple files and add documentation #14344
Conversation
…lib4 into docs-pullbacks
This is great! |
It looks good to me. I know this can be a penance, but you should run |
Yes, thanks! I was planning to ask about this (also I won't add myself as author for most files in the final version of this PR) |
PR summary fa6ea3ae90Import changesDependency changes
|
Fantastic! Thanks a lot! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
bors merge |
…les and add documentation (#14344) In this PR we split the file `CategoryTheory/Limits/Shapes/Pullbacks.lean` into 7 (!) smaller files and add documentation. This contribution was inspired by the AIM workshop "Formalizing algebraic geometry" in June 2024.
Pull request successfully merged into master. Build succeeded: |
In this PR we split the file
CategoryTheory/Limits/Shapes/Pullbacks.lean
into 7 (!) smaller files and add documentation.This contribution was inspired by the AIM workshop "Formalizing algebraic geometry" in June 2024.
This PR does not touch the code itself (except some lemma that I think had the wrong name by mistake, see the PR summary). In an upcoming PR I will golf & apply some fixes that I have noticed whilst going through this file, and in yet another PR I will add some API that I thought was missing whilst writing #14208