Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(CategoryTheory/Limits/Shapes/Pullbacks): split into multiple files and add documentation #14344

Closed
wants to merge 32 commits into from

Conversation

callesonne
Copy link
Collaborator

@callesonne callesonne commented Jul 1, 2024

In this PR we split the file CategoryTheory/Limits/Shapes/Pullbacks.lean into 7 (!) smaller files and add documentation.

This contribution was inspired by the AIM workshop "Formalizing algebraic geometry" in June 2024.


This PR does not touch the code itself (except some lemma that I think had the wrong name by mistake, see the PR summary). In an upcoming PR I will golf & apply some fixes that I have noticed whilst going through this file, and in yet another PR I will add some API that I thought was missing whilst writing #14208

Open in Gitpod

@callesonne callesonne added WIP Work in progress workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry labels Jul 1, 2024
@erdOne
Copy link
Member

erdOne commented Jul 1, 2024

This is great!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 1, 2024
@joelriou
Copy link
Collaborator

joelriou commented Jul 2, 2024

It looks good to me. I know this can be a penance, but you should run git blame (probably more on mathlib3...) so as to identify slightly more precisely the main authors of the different chunks.

@callesonne
Copy link
Collaborator Author

callesonne commented Jul 2, 2024

It looks good to me. I know this can be a penance, but you should run git blame (probably more on mathlib3...) so as to identify slightly more precisely the main authors of the different chunks.

Yes, thanks! I was planning to ask about this (also I won't add myself as author for most files in the final version of this PR)

Copy link

github-actions bot commented Jul 2, 2024

PR summary fa6ea3ae90

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Limits.Shapes.Pullbacks 400 0 -400 (-100.00%)

Declarations diff

+ PullbackCone.fst_limit_cone
+ PullbackCone.snd_limit_cone
++-- flip_pt
- PullbackCone.fst_colimit_cocone
- PullbackCone.snd_colimit_cocone

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@callesonne callesonne added awaiting-review t-category-theory Category theory and removed WIP Work in progress labels Jul 2, 2024
@erdOne
Copy link
Member

erdOne commented Jul 2, 2024

Fantastic! Thanks a lot!
maintainer merge.

Copy link

github-actions bot commented Jul 2, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@kim-em
Copy link
Contributor

kim-em commented Jul 3, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 3, 2024
…les and add documentation (#14344)

In this PR we split the file `CategoryTheory/Limits/Shapes/Pullbacks.lean` into 7 (!) smaller files and add documentation.

This contribution was inspired by the AIM workshop "Formalizing algebraic geometry" in June 2024.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory/Limits/Shapes/Pullbacks): split into multiple files and add documentation [Merged by Bors] - chore(CategoryTheory/Limits/Shapes/Pullbacks): split into multiple files and add documentation Jul 3, 2024
@mathlib-bors mathlib-bors bot closed this Jul 3, 2024
@mathlib-bors mathlib-bors bot deleted the docs-pullbacks branch July 3, 2024 01:30
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-category-theory Category theory workshop-AIM-AG-2024 This PR is associated with the 2024 AIM workshop on formalization of algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants