Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: delete obsolete porting scripts #14346

Closed
wants to merge 2 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jul 1, 2024

This is a more conservative version of #14314, deleting just the scripts that we should have deleted a year ago when the port finished.

Copy link

github-actions bot commented Jul 1, 2024

PR summary b77b26f730

Import changes

No significant changes to the import graph


Declarations diff

- condense(s):
- get_mathlib4_module_commit_info(contents):
- mk_label(path:
- update_file_header(file_path):

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor Author

kim-em commented Jul 1, 2024

See @grunweg's analysis at #14314 (review) confirming these scripts are all only useful during the port. He didn't include benchmark.sh, which I've also deleted here. This was solely to provide comparative benchmarking of the ported subset of mathlib3. (I wrote it.)

@grunweg
Copy link
Collaborator

grunweg commented Jul 2, 2024

Thanks for elaborating on benchmarks.sh, that context is definitely useful to have :-)
maintainer merge

Copy link

github-actions bot commented Jul 2, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
This is a more conservative version of #14314, deleting just the scripts that we should have deleted a year ago when the port finished.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: delete obsolete porting scripts [Merged by Bors] - chore: delete obsolete porting scripts Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the rm_obsolete_scripts2 branch July 2, 2024 17:55
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants