Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore (Algebra.Order.Monoid.Unbundled): don't used bundled structured in unbundled #14351

Closed

Conversation

mattrobball
Copy link
Collaborator

Using bundled ordered algebra in Algebra.Order.Monoid.Unbundled.Pow seems to defeat the purpose.


Open in Gitpod

…rderDual` to a new file `Algebra.Order.Monoid.Unbundled.OrderDual`. As a consequence, none of the unbundled ordered algebra now depend on bundled ordered algebra.
Copy link

github-actions bot commented Jul 2, 2024

PR summary 7b4f464745

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Monoid.Unbundled.Pow 183 181 -2 (-1.09%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor

kim-em commented Jul 2, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mattrobball
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 2, 2024
… in unbundled (#14351)

Using bundled ordered algebra in `Algebra.Order.Monoid.Unbundled.Pow` seems to defeat the purpose.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore (Algebra.Order.Monoid.Unbundled): don't used bundled structured in unbundled [Merged by Bors] - chore (Algebra.Order.Monoid.Unbundled): don't used bundled structured in unbundled Jul 2, 2024
@mathlib-bors mathlib-bors bot closed this Jul 2, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/move_unbundle_orderdual_under_unbundled branch July 2, 2024 12:53
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants