-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: make MorphismProperty.RespectsIso a typeclass #14353
Conversation
PR summary e2c69ac0fcImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
!bench |
Here are the benchmark results for commit c154949. |
!bench |
Here are the benchmark results for commit 2f36b97. |
Thanks a lot! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
Thanks! bors merge |
Most of the properties of properties of morphisms should be made typeclasses. For example, `IsMultiplicative`, `HasTwoOutOfThreeProperty` are already typeclasses (because it is convenient for the localization of categories). In this PR, `MorphismProperty.RespectsIso` is made a typeclass. One of the reasons to do so is that it should ease the development of the notion of "representable" morphisms of presheaves #14208. Another is that most of the reasonable properties of morphisms which we encounter satisfy this property: we should not have to remember the names of lemmas which assert this trivial property!
Pull request successfully merged into master. Build succeeded: |
Most of the properties of properties of morphisms should be made typeclasses. For example,
IsMultiplicative
,HasTwoOutOfThreeProperty
are already typeclasses (because it is convenient for the localization of categories). In this PR,MorphismProperty.RespectsIso
is made a typeclass. One of the reasons to do so is that it should ease the development of the notion of "representable" morphisms of presheaves #14208. Another is that most of the reasonable properties of morphisms which we encounter satisfy this property: we should not have to remember the names of lemmas which assert this trivial property!The main changes are in the file
CategoryTheory.MorphismProperty.Basic
.