Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/AdicCompletion): adic completion of Noetherian ring is flat #14366

Closed
wants to merge 7 commits into from

Conversation

chrisflav
Copy link
Collaborator

@chrisflav chrisflav commented Jul 2, 2024

We show that the adic completion of a Noetherian ring R is flat.

More precisely, we show that on finite modules over a Noetherian ring, tensoring a module M with the adic completion of R is the same as adically completing M. From this we conclude since adic completion on such modules is exact.

Co-authored-by: Judith Ludwig [email protected]


Open in Gitpod

@chrisflav chrisflav added awaiting-review awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

PR summary dd8f45e97e

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.AdicCompletion.AsTensorProduct 1172 1557 +385 (+32.85%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.AdicCompletion.AsTensorProduct 385

Declarations diff

+ flat_of_isNoetherian
+ isIso_of_isInitial
+ isIso_of_isTerminal
+ lTensorKerIncl
+ ofTensorProductEquivOfFiniteNoetherian
+ ofTensorProductEquivOfFiniteNoetherian_apply
+ ofTensorProductEquivOfFiniteNoetherian_symm_of
+ ofTensorProduct_bijective_of_finite_of_isNoetherian
+ ofTensorProduct_bijective_of_map_from_fin
+ ofTensorProduct_surjective_of_finite
+ tensor_map_id_left_eq_map
+ tensor_map_id_left_injective_of_injective
- ofTensorProduct_surjective_of_fg

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 12, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 14, 2024
@erdOne erdOne requested a review from riccardobrasca July 16, 2024 16:15
@riccardobrasca riccardobrasca self-assigned this Jul 17, 2024
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only question is whether it makes sense to keep on proving stuff about the completion rather than introducing a predicate IsAdicCompletion: we will surely want it, and you are just adding more work to adapt everything.

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 18, 2024
@chrisflav
Copy link
Collaborator Author

LGTM. My only question is whether it makes sense to keep on proving stuff about the completion rather than introducing a predicate IsAdicCompletion: we will surely want it, and you are just adding more work to adapt everything.

I agree, this is the last PR in this series though. Also I think that the flatness can be rather easily obtained for IsAdicCompletion by just transferring via the isomorphism.

@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 18, 2024
@riccardobrasca
Copy link
Member

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@chrisflav
Copy link
Collaborator Author

Thanks for the review!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2024
…s flat (#14366)

We show that the adic completion of a Noetherian ring `R` is flat.

More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact.

Co-authored-by: Judith Ludwig <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2024
…s flat (#14366)

We show that the adic completion of a Noetherian ring `R` is flat.

More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact.

Co-authored-by: Judith Ludwig <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2024
…s flat (#14366)

We show that the adic completion of a Noetherian ring `R` is flat.

More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact.

Co-authored-by: Judith Ludwig <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/AdicCompletion): adic completion of Noetherian ring is flat [Merged by Bors] - feat(RingTheory/AdicCompletion): adic completion of Noetherian ring is flat Jul 18, 2024
@mathlib-bors mathlib-bors bot closed this Jul 18, 2024
@mathlib-bors mathlib-bors bot deleted the jlcm/adic-tensorproduct.3 branch July 18, 2024 19:47
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants