-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(RingTheory/AdicCompletion): adic completion of Noetherian ring is flat #14366
Conversation
PR summary dd8f45e97e
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.RingTheory.AdicCompletion.AsTensorProduct | 1172 | 1557 | +385 (+32.85%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.RingTheory.AdicCompletion.AsTensorProduct |
385 |
Declarations diff
+ flat_of_isNoetherian
+ isIso_of_isInitial
+ isIso_of_isTerminal
+ lTensorKerIncl
+ ofTensorProductEquivOfFiniteNoetherian
+ ofTensorProductEquivOfFiniteNoetherian_apply
+ ofTensorProductEquivOfFiniteNoetherian_symm_of
+ ofTensorProduct_bijective_of_finite_of_isNoetherian
+ ofTensorProduct_bijective_of_map_from_fin
+ ofTensorProduct_surjective_of_finite
+ tensor_map_id_left_eq_map
+ tensor_map_id_left_injective_of_injective
- ofTensorProduct_surjective_of_fg
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
This PR/issue depends on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only question is whether it makes sense to keep on proving stuff about the completion rather than introducing a predicate IsAdicCompletion
: we will surely want it, and you are just adding more work to adapt everything.
I agree, this is the last PR in this series though. Also I think that the flatness can be rather easily obtained for |
bors d+ |
✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks for the review! bors r+ |
…s flat (#14366) We show that the adic completion of a Noetherian ring `R` is flat. More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact. Co-authored-by: Judith Ludwig <[email protected]>
This PR was included in a batch that was canceled, it will be automatically retried |
…s flat (#14366) We show that the adic completion of a Noetherian ring `R` is flat. More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact. Co-authored-by: Judith Ludwig <[email protected]>
Build failed (retrying...): |
…s flat (#14366) We show that the adic completion of a Noetherian ring `R` is flat. More precisely, we show that on finite modules over a Noetherian ring, tensoring a module `M` with the adic completion of `R` is the same as adically completing `M`. From this we conclude since adic completion on such modules is exact. Co-authored-by: Judith Ludwig <[email protected]>
Pull request successfully merged into master. Build succeeded: |
We show that the adic completion of a Noetherian ring
R
is flat.More precisely, we show that on finite modules over a Noetherian ring, tensoring a module
M
with the adic completion ofR
is the same as adically completingM
. From this we conclude since adic completion on such modules is exact.Co-authored-by: Judith Ludwig [email protected]