[Merged by Bors] - chore (Data.Nat.Cast.Order): split into Basic and Ring
#14371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 2e4409af3dImport changesDependency changes
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
1 task
kim-em
reviewed
Jul 3, 2024
Co-authored-by: Kim Morrison <[email protected]>
kim-em
reviewed
Jul 3, 2024
kim-em
reviewed
Jul 3, 2024
|
bors d+ |
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Kim Morrison <[email protected]>
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
We split `Data.Nat.Cast.Order` into `Data.Nat.Cast.Order.Basic` which only uses unbundled ordered algebra classes and `Data.Nat.Cast.Order.Ring` which uses bundled ordered algebra classes. This avoids importing bundled ordered algebra until later downstream. Co-authored-by: Matthew Robert Ballard <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Basic and Ring Basic and Ring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split
Data.Nat.Cast.OrderintoData.Nat.Cast.Order.Basicwhich only uses unbundled ordered algebra classes andData.Nat.Cast.Order.Ringwhich uses bundled ordered algebra classes. This avoids importing bundled ordered algebra until later downstream.