-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore (Algebra.Order.Group.Defs): split out unbundled ordered algebra results to Algebra.Order.Group.Unbundled.Basic
#14380
Conversation
PR summary aca313f01b
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Order.Group.OrderIso | 226 | 225 | -1 (-0.44%) |
Mathlib.Order.ConditionallyCompleteLattice.Group | 346 | 345 | -1 (-0.29%) |
Import changes for all files
Files | Import difference |
---|---|
Too many changes (2872)! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Import changes for all files
Technically, the import difference can be displayed. |
@adomani Can this compute the change in the number of leaves in the import graph over a module? |
I am not sure how to read the change in number of leaves from the current data, but the number of leaves can certainly be computed! In fact, I wonder whether "transitive imports" is really what we should be looking at. Maybe something like "number of covering relations" or "average number of covering relations" might be a better statistic. After all, we would like to distinguish an import system like
from a complete graph on 5 vertices and I am not sure which statistic would make the two "clearly" different. |
bors merge |
… results to `Algebra.Order.Group.Unbundled.Basic` (#14380) Currently, you have to import bundled ordered algebra to use these facts about unbundled ordered algebra classes. This should be unnecessary.
Pull request successfully merged into master. Build succeeded: |
Algebra.Order.Group.Unbundled.Basic
Algebra.Order.Group.Unbundled.Basic
Currently, you have to import bundled ordered algebra to use these facts about unbundled ordered algebra classes. This should be unnecessary.