-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Topology/LocallyClosed): Define locally closed sets #14396
Conversation
erdOne
commented
Jul 4, 2024
PR summary dd9ad5240fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me.
Please open the Set
namespace and remove Set.
prefixes.
Co-authored-by: Floris van Doorn <[email protected]>
…lib4 into erd1/locallyClosed
…mmunity/mathlib4 into erd1/locallyClosed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
One more comments, otherwise LGTM bors d+ |
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Co-authored-by: Andrew Yang <[email protected]>
Pull request successfully merged into master. Build succeeded: |