Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/LocallyClosed): Define locally closed sets #14396

Closed
wants to merge 13 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jul 4, 2024


Open in Gitpod

Copy link

github-actions bot commented Jul 4, 2024

PR summary dd9ad5240f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.LocallyClosed 686

Declarations diff

+ Continuous.preimage_coborder_subset
+ Embedding.isLocallyClosed_iff
+ Inducing.isLocallyClosed_iff
+ IsClosed.coborder_eq
+ IsClosed.isLocallyClosed
+ IsLocallyClosed
+ IsLocallyClosed.image
+ IsLocallyClosed.inter
+ IsLocallyClosed.isOpen_coborder
+ IsLocallyClosed.isOpen_preimage_val_closure
+ IsLocallyClosed.preimage
+ IsOpen.coborder_eq
+ IsOpen.isLocallyClosed
+ IsOpenMap.coborder_preimage_subset
+ OpenEmbedding.coborder_preimage
+ closure_inter_coborder
+ coborder
+ coborder_eq_compl_frontier_iff
+ coborder_eq_union_frontier_compl
+ coborder_eq_univ_iff
+ coborder_inter_closure
+ coborder_preimage
+ disjoint_frontier_iff_isOpen
+ frontier_subset_iff_isClosed
+ isClosed_preimage_val
+ isClosed_preimage_val_coborder
+ isLocallyClosed_iff_coe_preimage_of_iSup_eq_top
+ isLocallyClosed_iff_isOpen_coborder
+ isLocallyClosed_tfae
+ subset_coborder
++++ _

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@erdOne erdOne added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebraic-geometry Algebraic geometry labels Jul 4, 2024
@fpvandoorn fpvandoorn self-assigned this Jul 13, 2024
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me.

Please open the Set namespace and remove Set. prefixes.

@fpvandoorn fpvandoorn added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 13, 2024
erdOne and others added 4 commits July 14, 2024 10:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 14, 2024
@fpvandoorn
Copy link
Member

One more comments, otherwise LGTM

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 14, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@erdOne
Copy link
Member Author

erdOne commented Jul 14, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 14, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/LocallyClosed): Define locally closed sets [Merged by Bors] - feat(Topology/LocallyClosed): Define locally closed sets Jul 14, 2024
@mathlib-bors mathlib-bors bot closed this Jul 14, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/locallyClosed branch July 14, 2024 16:48
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebraic-geometry Algebraic geometry t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants