Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Logic/Basic): deprecate Classical.subtype_of_exists #14420

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 4, 2024

Also golf its only use in the library.


Open in Gitpod

Also golf its only use in the library.
@urkud urkud added awaiting-review t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

PR summary 45cc9c708c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Thanks for doing this!
maintainer merge

Copy link

github-actions bot commented Jul 4, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 4, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Logic/Basic): deprecate Classical.subtype_of_exists [Merged by Bors] - chore(Logic/Basic): deprecate Classical.subtype_of_exists Jul 4, 2024
@mathlib-bors mathlib-bors bot closed this Jul 4, 2024
@mathlib-bors mathlib-bors bot deleted the YK-logic-deprecate branch July 4, 2024 22:44
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants