-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: Golf Finset.exists_subsuperset_card_eq
#14425
Conversation
Thanks Bhavik!
PR summary 9e57acb865Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
replace hk : n + k = card (erase t a) := by rw [card_erase_of_mem (mem_sdiff.1 ha).1]; omega | ||
obtain ⟨u, hsu, hut, hu⟩ := ih hst hk | ||
exact ⟨u, hsu, hut.trans (erase_subset ..), hu⟩ | ||
refine Nat.decreasingInduction' ?_ hnt ⟨t, by simp [hst]⟩ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bugged me, so I've made a start on #14431
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nerdsniping Eric is the best kind of nerdsnipe 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the best possible outcome of this golf :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I wrote it, so someone else should review too.
I'd prefer to block this on #14431, to motivate review there once I finish up in an hour or so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I can't actually make decreasingInduction'
work with induction
after all, it's not an induction principle in the usual sense because the inductive step depends on the original value.
bors merge
Pull request successfully merged into master. Build succeeded: |
Finset.exists_subsuperset_card_eq
Finset.exists_subsuperset_card_eq
Thanks Bhavik!