Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Golf Finset.exists_subsuperset_card_eq #14425

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Thanks Bhavik!


Open in Gitpod

Copy link

github-actions bot commented Jul 4, 2024

PR summary 9e57acb865

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@YaelDillies YaelDillies added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 4, 2024
replace hk : n + k = card (erase t a) := by rw [card_erase_of_mem (mem_sdiff.1 ha).1]; omega
obtain ⟨u, hsu, hut, hu⟩ := ih hst hk
exact ⟨u, hsu, hut.trans (erase_subset ..), hu⟩
refine Nat.decreasingInduction' ?_ hnt ⟨t, by simp [hst]⟩
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bugged me, so I've made a start on #14431

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nerdsniping Eric is the best kind of nerdsnipe 😝

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the best possible outcome of this golf :D

Copy link
Collaborator

@rwst rwst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I wrote it, so someone else should review too.

@eric-wieser
Copy link
Member

I'd prefer to block this on #14431, to motivate review there once I finish up in an hour or so

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I can't actually make decreasingInduction' work with induction after all, it's not an induction principle in the usual sense because the inductive step depends on the original value.

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 5, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Golf Finset.exists_subsuperset_card_eq [Merged by Bors] - chore: Golf Finset.exists_subsuperset_card_eq Jul 6, 2024
@mathlib-bors mathlib-bors bot closed this Jul 6, 2024
@mathlib-bors mathlib-bors bot deleted the golf_exists_subsuperset_card_eq branch July 6, 2024 00:06
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants