-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add lemma not_mem_singleton_iff #14443
Conversation
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
Co-authored-by: Dagur Tómas Ásgeirsson <[email protected]>
PR summary 371bc73f7fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
This PR includes some Grothendieck construction stuff, which it shouldn't, according to the PR description |
So, I think this is because I am doing something wrong: I have only one mathlib repo locally, and do all my PRs from that. I do follow the Mathlib contribution guidelines in switching branches first, but nevertheless I get the problem that this PR for sets shows up as a continuation of |
|
Just did that. Would the next step be for the current PR (i.e. not_mem_singleton_iff) be to commit the change (i.e. resetting Grothendieck.lean back to the master version) and push? |
Yes. |
Thanks! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
not_mem_singleton_iff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
The contrapositive (?) of the lemma ``` theorem mem_singleton_iff {a b : α} : a ∈ ({b} : Set α) ↔ a = b := Iff.rfl ``` was missing. This PR adds ``` @[simp] theorem not_mem_singleton_iff {a b : α} : a ∉ ({b} : Set α) ↔ a ≠ b := Iff.rfl ``` which can be useful in avoiding extra `have` statements in other proofs.
Pull request successfully merged into master. Build succeeded: |
The contrapositive (?) of the lemma
was missing. This PR adds
which can be useful in avoiding extra
have
statements in other proofs.