-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ContinuousFunctionalCalculus): Define the real log based on the CFC #14448
Conversation
PR summary ec1d025449Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
lemma NormedSpace.exp_continuousMap_eq (f : C(α, 𝕜)) : | ||
exp 𝕜 f = (⟨exp 𝕜 ∘ f, Continuous.comp exp_continuous f.continuous⟩ : C(α, 𝕜)) := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this lemma should belong with NormedSpace.exp
, but none of those files have the right imports. #find_home
tells me to put it in Mathlib.Analysis.NormedSpace.Spectrum
, but that feels even more out of place than just leaving it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very annoying that aesop
won't prove (∀ x ∈ spectrum ℝ a, 0 < x) → ∀ x ∈ spectrum ℝ a, x ≠ 0
, but I also don't think we can make ne_of_gt
or its synonyms into an aesop
lemma (they would match too much, and they are very unsafe
). It would be nice if we had some automation to handle this.
It would also be nice to have ways to customize the fun_prop
part of cfc_cont_tac
after the fact, maybe with some options? We should think about this. Because it would be good to add the necessary details (like the x ≠ 0
bit above), and then set an option to make cfc_cont_tac
do what we need it to, without forcing ourselves to manually apply fun_prop
with special dischargers.
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
Mathlib/Analysis/SpecialFunctions/ContinuousFunctionalCalculus/ExpLog.lean
Outdated
Show resolved
Hide resolved
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
…/ExpLog.lean Co-authored-by: Jireh Loreaux <[email protected]>
Yes, we should think about this at some point. I think it's an instance of a much more general problem though: how do we automatize goals like |
bors merge |
…CFC (#14448) This PR defines `CFC.log` as `cfc Real.log`, and shows its basic properties, such as the fact that it's the inverse of `NormedSpace.exp ℝ`. Along the way, we also show that the exponential defined via the CFC is equal to `NormedSpace.exp`, which is defined via power series. Co-authored-by: Frédéric Dupuis <[email protected]>
Pull request successfully merged into master. Build succeeded: |
This PR defines
CFC.log
ascfc Real.log
, and shows its basic properties, such as the fact that it's the inverse ofNormedSpace.exp ℝ
. Along the way, we also show that the exponential defined via the CFC is equal toNormedSpace.exp
, which is defined via power series.