[Merged by Bors] - chore (Algebra.PUnitInstances): split file into Algebra, Order, and Module instance files
#14461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary e200a23ca2
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Category.MonCat.Basic | 466 | 426 | -40 (-8.58%) |
| Mathlib.CategoryTheory.Monoidal.Mon_ | 495 | 460 | -35 (-7.07%) |
| Mathlib.Algebra.Category.Grp.Basic | 468 | 442 | -26 (-5.56%) |
| Mathlib.GroupTheory.Coprod.Basic | 557 | 542 | -15 (-2.69%) |
| Mathlib.Algebra.Ring.BooleanRing | 509 | 499 | -10 (-1.96%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (2023)! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
1 task
grunweg
reviewed
Jul 9, 2024
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
1 similar comment
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
bors d+ |
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: grunweg <[email protected]>
Co-authored-by: grunweg <[email protected]>
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
…nd `Module` instance files (#14461) When we need algebra structures on `PUnit`, we should be more surgical about what we are importing. Co-authored-by: Matthew Robert Ballard <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Algebra, Order, and Module instance files Algebra, Order, and Module instance files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we need algebra structures on
PUnit, we should be more surgical about what we are importing.