Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: define topology on DomMulAct _ #14493

Closed
wants to merge 5 commits into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 7, 2024


Open in Gitpod

Copy link

github-actions bot commented Jul 7, 2024

PR summary 8d9d9ca65e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Algebra.Constructions.DomMulAct 665

Declarations diff

+ Embedding.t25Space
+ Subtype.instT25Space
+ closedEmbedding_mk
+ closedEmbedding_mk_symm
+ coe_mkHomeomorph
+ coe_mkHomeomorph_symm
+ comap_mk.symm_nhds
+ comap_mk_nhds
+ continuous_mk
+ continuous_mk_symm
+ embedding_mk
+ embedding_mk_symm
+ inducing_mk
+ inducing_mk_symm
+ instCompletelyNormalSpace
+ instDiscreteTopology
+ instFirstCountableTopology
+ instNormalSpace
+ instR0Space
+ instR1Space
+ instRegularSpace
+ instSecondCountableTopology
+ instSeparableSpace
+ instT0Space
+ instT1Space
+ instT25Space
+ instT2Space
+ instT3Space
+ instT4Space
+ instT5Space
+ instTopologicalSpace
+ map_mk_nhds
+ map_mk_symm_nhds
+ mkHomeomorph
+ openEmbedding_mk
+ openEmbedding_mk_symm
+ quotientMap_mk
+ quotientMap_mk_symm
- instance [T25Space X] {p : X → Prop} : T25Space {x // p x}

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@urkud urkud added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields, etc) t-dynamics Dynamical Systems awaiting-CI labels Jul 7, 2024
/-!
# Topological structure on `DomMulAct _`

In this file we define topology on `DomMulAct _` and prove basic facts about this topology.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain here that the topology on DomMulAct X is the same as the one on X?

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 7, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jul 7, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 7, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: define topology on DomMulAct _ [Merged by Bors] - feat: define topology on DomMulAct _ Jul 7, 2024
@mathlib-bors mathlib-bors bot closed this Jul 7, 2024
@mathlib-bors mathlib-bors bot deleted the YK-dma-top branch July 7, 2024 23:36
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated t-algebra Algebra (groups, rings, fields, etc) t-dynamics Dynamical Systems t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants