Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Stream/Init): use instead of Nat consistently #14521

Closed
wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jul 8, 2024

The file currently uses a mix of these: use the nice unicode character, since we can.


Open in Gitpod

The file currently uses a mix of these: use the nice unicode character,
while we're at it.
@grunweg grunweg added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 8, 2024
@grunweg grunweg requested a review from Komyyy July 8, 2024 16:24
Copy link

github-actions bot commented Jul 8, 2024

PR summary f508318fcb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@j-loreaux
Copy link
Collaborator

I'm actually tempted to leave this as Nat in case any of this gets upstreamed at some point, where the notation is not avaiable.

@semorrison what do you think here?

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 8, 2024

That is a reasonable argument, in principle. Note that the file is currently inconsistent about this.

Copy link
Collaborator

@Komyyy Komyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks reasonable!
A further request from me is that Stream.Defs should also be edited.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 10, 2024
@Komyyy Komyyy added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 11, 2024
@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 11, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jul 11, 2024

This PR looks reasonable! A further request from me is that Stream.Defs should also be edited.

Done!

@Parcly-Taxel Parcly-Taxel changed the title chore(Data/Stream/Init): use \N instead of Nat consistently chore(Data/Stream/Init): use instead of Nat consistently Jul 11, 2024
@Komyyy
Copy link
Collaborator

Komyyy commented Jul 15, 2024

@grunweg Thank you!

@j-loreaux
Copy link
Collaborator

I asked Kim and they were fine with this.

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
The file currently uses a mix of these: use the nice unicode character, since we can.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Stream/Init): use instead of Nat consistently [Merged by Bors] - chore(Data/Stream/Init): use instead of Nat consistently Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the MR-tweak-stream-init branch July 16, 2024 19:07
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants