-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Stream/Init): use ℕ
instead of Nat
consistently
#14521
Conversation
The file currently uses a mix of these: use the nice unicode character, while we're at it.
PR summary f508318fcbImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
I'm actually tempted to leave this as @semorrison what do you think here? |
That is a reasonable argument, in principle. Note that the file is currently inconsistent about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks reasonable!
A further request from me is that Stream.Defs
should also be edited.
Done! |
ℕ
instead of Nat
consistently
@grunweg Thank you! |
I asked Kim and they were fine with this. bors merge |
The file currently uses a mix of these: use the nice unicode character, since we can.
Pull request successfully merged into master. Build succeeded: |
ℕ
instead of Nat
consistentlyℕ
instead of Nat
consistently
The file currently uses a mix of these: use the nice unicode character, since we can.