Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove superfluous open statements #14543

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jul 8, 2024

Not exhaustive: hand-minimized in a few selected files


Open in Gitpod

Not exhaustive: hand-minimized in a few selected files
@grunweg grunweg added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 8, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jul 8, 2024

Could this affect performance in any way, or is this me being paranoid?

Copy link

github-actions bot commented Jul 8, 2024

PR summary 313804c74b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
Not exhaustive: hand-minimized in a few selected files
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove superfluous open statements [Merged by Bors] - chore: remove superfluous open statements Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-remove-superfluous-open branch July 9, 2024 10:53
@grunweg
Copy link
Collaborator Author

grunweg commented Jul 9, 2024

Thank you for the fast review!

@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants