Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Congruence subgroup namespace #14573

Closed
wants to merge 3 commits into from

Conversation

CBirkbeck
Copy link
Collaborator

@CBirkbeck CBirkbeck commented Jul 9, 2024

Put congruence subgroups into their own namespace, so that things like Gamma don't live in the root namespace.


Open in Gitpod

@CBirkbeck CBirkbeck added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

PR summary 6b053dd002

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 9, 2024
@loefflerd
Copy link
Collaborator

LGTM. I don't know why the bot removed the "blocked by other PR" label, though.

Maintainers: please merge this once #14572 is in.

maintainer merge

Copy link

github-actions bot commented Jul 9, 2024

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Canceled.

@CBirkbeck
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
Put congruence subgroups into their own namespace, so that things like `Gamma` don't live in the root namespace.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title Congruence subgroup namespace [Merged by Bors] - Congruence subgroup namespace Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the congruence_subgroup_namespace branch July 9, 2024 19:36
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants