[Merged by Bors] - chore: make Algebra.cast reducible
#14601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command-Master
added
WIP
github-actions
bot
added
the
new-contributor
PR summary 90724c6935Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
eric-wieser
approved these changes
Jul 11, 2024
Command-Master
changed the title
Algebra.cast reducibleAlgebra.cast reducible
Vierkantor
reviewed
Jul 11, 2024
Vierkantor
added
the
awaiting-author
Vierkantor
added a commit
that referenced
this pull request
Jul 11, 2024
This came up in #14601: it seems this `simp` lemma is missing, and the `simp` set wouldn't converge. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Should.20docs.23Complex.2Econj_ofReal.20be.20.60.40.5Bsimp.5D.60.3F
|
!bench |
Command-Master
removed
the
awaiting-author
|
Here are the benchmark results for commit 90724c6. |
|
Looks good to me, thank you! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
Make `Algebra.cast` `@[reducible]`
|
Also: good idea to run a benchmark :) |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Algebra.cast reducibleAlgebra.cast reducible
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
This came up in #14601: it seems this `simp` lemma is missing, and as a consequence the `simp` set wouldn't converge. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Should.20docs.23Complex.2Econj_ofReal.20be.20.60.40.5Bsimp.5D.60.3F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Algebra.cast@[reducible]