Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Fintype/Order): Slightly strengthen Fin.completeLinearOrder. #14616

Closed

Conversation

linesthatinterlace
Copy link
Collaborator

Adds a CompleteLinearOrder instance for [NeZero n] Fin n.


Recently an instance of BoundedOrder was added for [NeZero n] Fin n, rather than just Fin (n + 1). This adds the corresponding instance of CompleteLinearOrder.

Open in Gitpod

Copy link

PR summary d73915f842

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@kim-em
Copy link
Contributor

kim-em commented Jul 10, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 10, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 10, 2024

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 10, 2024

Already running a review

mathlib-bors bot pushed a commit that referenced this pull request Jul 10, 2024
…der`. (#14616)

Adds a `CompleteLinearOrder` instance for `[NeZero n] Fin n`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Fintype/Order): Slightly strengthen Fin.completeLinearOrder. [Merged by Bors] - feat(Data/Fintype/Order): Slightly strengthen Fin.completeLinearOrder. Jul 10, 2024
@mathlib-bors mathlib-bors bot closed this Jul 10, 2024
@mathlib-bors mathlib-bors bot deleted the linesthatinterlace/fin_completelinearorder branch July 10, 2024 18:10
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants