Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: remove an unused import; add a missing docstring bracket #14629

Closed
wants to merge 1 commit into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jul 10, 2024


Open in Gitpod

Two unrelated minor fixes which I noticed when reviewing another PR.

@kbuzzard kbuzzard added documentation Improvements or additions to documentation awaiting-CI labels Jul 10, 2024
Copy link

PR summary 2316930cdc

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Limits.ConcreteCategory 518 517 -1 (-0.19%)
Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Limits.ConcreteCategory Mathlib.CategoryTheory.Limits.Shapes.ConcreteCategory -1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@kbuzzard kbuzzard changed the title fix: remove an unused import; add a missing bracket fix: remove an unused import; add a missing docstring bracket Jul 10, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 11, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: remove an unused import; add a missing docstring bracket [Merged by Bors] - fix: remove an unused import; add a missing docstring bracket Jul 11, 2024
@mathlib-bors mathlib-bors bot closed this Jul 11, 2024
@mathlib-bors mathlib-bors bot deleted the kbuzzard-concrete-category-fixes branch July 11, 2024 09:13
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants