[Merged by Bors] - refactor: improvements to lint_style #14676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it forgot to mention style exceptions files
When updating style exceptions, we want to batch all modules to lint: this prepares the code accordingly, and is also slightly cleaner as it moves the parsing of import-only files to the script itself.
This will be useful for re-generating the style exceptions file. chore: also parse the particular error message with the copyright, since we can (and have these in the nolints file). Also avoid normalising the current size for file length errors.
PR summary 009289ca5bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
It's debatable whether we want the normalisation at all; but let's rather use none than an empty string (which prints the wrong out).
Closed
1 task
and the number of characters in the long line warning. Both information is necessary for regenerating the style exceptions file.
grunweg
force-pushed
the
MR-refactor-lint-style
branch
from
ab0e446 to
6cb9265
Compare
kim-em
reviewed
Jul 13, 2024
kim-em
reviewed
Jul 13, 2024
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
To prepare for #14273; pulled out for easy of reviewing. Commits can be reviewed individually. Co-authored-by: Kim Morrison <[email protected]>
|
Thank you for the fast review! |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for #14273; pulled out for easy of reviewing.
Commits can be reviewed individually.