[Merged by Bors] - chore: remove two mathport syntax stubs #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That tactic exists now, and (in the words of its Lean 4 author) can be improved further, but it is certainly not a stub any more. rw_search? seems to be not implemented yet
This now exists as #register_hint. Does this need a change in mathport first? Or am I overlooking something?
grunweg
added
the
tech debt
PR summary 5635f8abc6Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
jcommelin
reviewed
Jul 15, 2024
Mathlib/Mathport/Syntax.lean
Outdated
| @@ -225,7 +225,6 @@ syntax generalizingClause := " generalizing" (ppSpace ident)+ | |||
| /- E -/ syntax (name := nthRwLHS) "nth_rw_lhs " num rwRuleSeq (location)? : tactic | |||
| /- E -/ syntax (name := nthRwRHS) "nth_rw_rhs " num rwRuleSeq (location)? : tactic | |||
|
|
|||
| /- S -/ syntax (name := rwSearch) "rw_search" (config)? rwRuleSeq : tactic | |||
| /- S -/ syntax (name := rwSearch?) "rw_search?" (config)? rwRuleSeq : tactic | |||
There was a problem hiding this comment.
I think this one can also be dropped, since rw? has been implemented.
cc @semorrison
There was a problem hiding this comment.
Pushed a commit dropping this.
grunweg
commented
Jul 15, 2024
grunweg
commented
Jul 15, 2024
grunweg
commented
Jul 15, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
The `hint` and `rw_search` tactics have been implemented by now.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
The `hint` and `rw_search` tactics have been implemented by now.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hintandrw_searchtactics have been implemented by now.