[Merged by Bors] - fix: only run the missingEnd linter in mathlib and related projects #14696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [zulip discussion](TODO).
PR summary 2b2ceb1580Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
kim-em
reviewed
Jul 15, 2024
Comment on lines
+178
to
+179
| unless #[`Mathlib, `test, `Archive, `Counterexamples].contains (← getMainModule).getRoot do | ||
| return |
There was a problem hiding this comment.
I think it would be good to reference leanprover/lean4#3403 here, as a breadcrumb for providing options to control this when they (soon!) become available.
There was a problem hiding this comment.
Good idea! I've mentioned this PR, here and for the setOption linter also.
|
bors d+ |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
(Please update PR title before merging) |
grunweg
changed the title
|
Thanks for the review! bors r+ |
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zulip discussion.