Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Tactic/Ring/Basic): reduce use of autoImplicit #14709

Closed
wants to merge 24 commits into from

Conversation

grunweg added 2 commits July 13, 2024 16:55
This is almost exhaustive: I need help with two declarations in Pow,
and BigOperators is not quite as obvious.
@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 13, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 13, 2024
@grunweg grunweg changed the title chore(Mathlib(Tactic): reduce use of autoImplicit, part 1 [tracking] chore(Mathlib(Tactic): reduce use of autoImplicit Jul 14, 2024
@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 14, 2024
@grunweg grunweg changed the title [tracking] chore(Mathlib(Tactic): reduce use of autoImplicit chore(Mathlib(Tactic): reduce use of autoImplicit, part 3 Jul 14, 2024
@grunweg grunweg added blocked-by-core-PR This PR depends on a PR to Core/Std and removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 14, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Jul 14, 2024
@grunweg grunweg removed the blocked-by-core-PR This PR depends on a PR to Core/Std label Jul 14, 2024
Copy link

github-actions bot commented Jul 15, 2024

PR summary f84f41116e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 15, 2024
@grunweg grunweg force-pushed the MR-autoImplicit-tactic branch from c95fc12 to 5ef5afc Compare July 15, 2024 22:49
@grunweg grunweg changed the title chore(Tactic): reduce use of autoImplicit, part 4 chore(Tactic): reduce use of autoImplicit, part 5 Jul 16, 2024
@grunweg grunweg added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 16, 2024
@grunweg grunweg force-pushed the MR-autoImplicit-tactic branch from 33a0934 to e67e66c Compare July 16, 2024 23:29
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 17, 2024
@grunweg grunweg force-pushed the MR-autoImplicit-tactic branch from 64adc2e to 0c4b182 Compare July 18, 2024 22:48
@grunweg grunweg changed the title chore(Tactic): reduce use of autoImplicit, part 5 chore(Tactic/Ring/Basic): reduce use of autoImplicit Jul 18, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 19, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 19, 2024

Thanks for the fast review!
Let's try: does bors merge also work for me? Edit: yes, it does --- nice!
bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Tactic/Ring/Basic): reduce use of autoImplicit [Merged by Bors] - chore(Tactic/Ring/Basic): reduce use of autoImplicit Jul 19, 2024
@mathlib-bors mathlib-bors bot closed this Jul 19, 2024
@mathlib-bors mathlib-bors bot deleted the MR-autoImplicit-tactic branch July 19, 2024 08:51
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants