[Merged by Bors] - chore: separate dependent typeclass assumptions #14746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 5161a43bf8Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
|
Can you generate doc pages for both versions (or otherwise pretty-print all theorems in the file) and compare them? |
mattrobball
approved these changes
Jul 18, 2024
|
Thanks! bors delegate+ |
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Matthew Robert Ballard <[email protected]>
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
Flagged by the linter at #14731. If you are reviewing, there is a challenge: sectioning off `IsDomain` from `IsDedekindDomain` means that a lemma that before this PR had both in scope and actually really used `IsDomain` has suddenly become "worse", since now it only has `IsDedekindDomain` in scope. I am thinking about how to automatically address this challenge, but for the moment, this is what there is! 😄
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagged by the linter at #14731.
If you are reviewing, there is a challenge: sectioning off
IsDomainfromIsDedekindDomainmeans that a lemma that before this PR had both in scope and actually really usedIsDomainhas suddenly become "worse", since now it only hasIsDedekindDomainin scope.I am thinking about how to automatically address this challenge, but for the moment, this is what there is! 😄