Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Control): move files from Init/Control/ to Control/ #14755

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(Control): move files from Init/Control/ to Control/ #14755

wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Jul 15, 2024 •
edited
Loading

Open in Gitpod

@jcommelin jcommelin added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

PR summary f1cf8f2a2a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Init.Control.Lawful -15
Mathlib.Init.Control.Combinators -3
Mathlib.Control.Combinators 3
Mathlib.Control.Lawful 15

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

grunweg
grunweg reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable (but I am not an expert on this part of mathlib).
maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@kim-em
Copy link
Contributor

kim-em commented Jul 15, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 15, 2024
@jcommelin
chore(Control): move files from Init/Control/ to Control/ (#14755)
7052367
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Control): move files from Init/Control/ to Control/ [Merged by Bors] - chore(Control): move files from Init/Control/ to Control/ Jul 15, 2024
@mathlib-bors mathlib-bors bot closed this Jul 15, 2024
@mathlib-bors mathlib-bors bot deleted the jmc-mv-init-control branch July 15, 2024 17:07
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg left review comments

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcommelin @kim-em @grunweg