-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove superfluous ge_iff_le
#14785
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were likely introduced by calling simp?, but are not necessary. This is fixed in leanprover/lean4#4567, so now might be a good time for cleaning them up.
PR summary bbfbc385f3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
mo271
commented
Jul 16, 2024
mo271
commented
Jul 16, 2024
Nice! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
These were likely introduced by calling simp?, but are not necessary. This is fixed in leanprover/lean4#4567, so now might be a good time for cleaning them up. Co-authored-by: Moritz Firsching <[email protected]>
Pull request successfully merged into master. Build succeeded: |
ge_iff_le
ge_iff_le
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were likely introduced by calling simp?, but are not necessary.
This is fixed in leanprover/lean4#4567, so now might be a good time for cleaning them up.