Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(GroupTheory/PGroup,Sylow): Replace Fintype.card with Nat.card #14789

Closed
wants to merge 4 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Jul 16, 2024

A lot of the group theory library still needs to be switched over from Fintype.card to Nat.card. This PR switches over GroupTheory/PGroup.lean and GroupTheory/Sylow (there was enough dependence between the two that it was simplest to do them together).


Open in Gitpod

@tb65536 tb65536 added awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

PR summary 36856c7b14

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Sylow.finite_of_injective
+ Sylow.finite_of_ker_is_pGroup
+ _root_.exists_prime_orderOf_dvd_card'
+ instance (H : Subgroup G) [Finite (Sylow p G)] : Finite (Sylow p H)
+ instance [Fact p.Prime] [Finite (Sylow p G)] (P : Sylow p G) :
+ isCyclic_of_card_dvd_prime
- Sylow.fintypeOfInjective
- Sylow.fintypeOfKerIsPGroup
- instance (H : Subgroup G) [Finite (Sylow p G)] : Finite (Sylow p H) := by
- instance (H : Subgroup G) [Fintype (Sylow p G)] : Fintype (Sylow p H)
- instance [Fact p.Prime] [Fintype (Sylow p G)] (P : Sylow p G) :

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 17, 2024
#14789)

A lot of the group theory library still needs to be switched over from Fintype.card to Nat.card. This PR switches over GroupTheory/PGroup.lean and GroupTheory/Sylow (there was enough dependence between the two that it was simplest to do them together).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(GroupTheory/PGroup,Sylow): Replace Fintype.card with Nat.card [Merged by Bors] - refactor(GroupTheory/PGroup,Sylow): Replace Fintype.card with Nat.card Jul 17, 2024
@mathlib-bors mathlib-bors bot closed this Jul 17, 2024
@mathlib-bors mathlib-bors bot deleted the tb_fin1 branch July 17, 2024 06:49
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants