Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(NumberTheory/SiegelsLemma): replace Fin m and Fin n with Fintype α and Fintype β #14797

Closed
wants to merge 9 commits into from

Conversation

fbarroero
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

PR summary 5c1b12fd69

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@riccardobrasca
Copy link
Member

This is strictly more general than the current version, thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

✌️ fbarroero can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@fbarroero
Copy link
Collaborator Author

This is strictly more general than the current version, thanks!

bors d+

Thanks!

bors r+

@fbarroero
Copy link
Collaborator Author

✌️ fbarroero can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Already running a review

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/SiegelsLemma): replace Fin m and Fin n with Fintype α and Fintype β [Merged by Bors] - feat(NumberTheory/SiegelsLemma): replace Fin m and Fin n with Fintype α and Fintype β Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the siegelFin branch July 16, 2024 12:46
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants