[Merged by Bors] - feat(Polynomial/AlgebraMap): add mapAlgHom
#14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing theorems Moved `eval₂AlgHom'` out of `aeval` section and into the previous `CommSemiring` section Added a theorem relating `mapAlgHom` and `eval₂AlgHom'`.
github-actions
bot
added
the
new-contributor
PR summary da14ff5df8Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
quangvdao
changed the title
mapAlgHom
kim-em
reviewed
Jul 16, 2024
kim-em
added
the
awaiting-author
quangvdao
added
awaiting-CI
and removed
awaiting-author
|
Sorry but I think I made a mistake. The instance `Algebra (Polynomial R) (Polynomial A)` cannot be inferred automatically. And that should not be added to mathlib in my opinion, since potentially the intermediate X is not necessary map to X.
|
|
@acmepjz: yeah, I agree. So let's just go ahead and add |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
Add `Polynomial.mapAlgHom` as an algebra homomorphism between two polynomial rings, extending `Polynomial.mapRingHom`. Provide supporting theorems for `mapAlgHom`. Moved `Polynomial.eval₂AlgHom'` to earlier in `AlgebraMap.lean` , so that I can provide a theorem linking `mapAlgHom` and `eval₂AlgHom'`, without having to put `mapAlgHom` stuff after `aeval`. Co-authored-by: Quang Dao <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mapAlgHommapAlgHom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Polynomial.mapAlgHomas an algebra homomorphism between two polynomial rings, extendingPolynomial.mapRingHom. Provide supporting theorems formapAlgHom.Moved
Polynomial.eval₂AlgHom'to earlier inAlgebraMap.lean, so that I can provide a theorem linkingmapAlgHomandeval₂AlgHom', without having to putmapAlgHomstuff afteraeval.