[Merged by Bors] - chore(Mathlib/Tactic/ToAdditive/Frontend): isolate the to_additive attribute implementation in a new file Tactic.ToAdditive.Frontend (1/2)
#14816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic.ToAdditive.Frontend`
Komyyy
added
awaiting-CI
tech debt
PR summary 0d18829320Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
|
@jcommelin |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
bors d+ bors merge |
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
…attribute implementation in a new file `Tactic.ToAdditive.Frontend` (1/2) (#14816) Ideally, we want to move the `attribute [to_additive]` commands in `Init.ZeroOne` into `Tactic.ToAdditive` without any other changes. However, the `to_additive` attribute is initialized in the file and cannot be included in the same file. So it would be necessary to isolate the original `to_additive` attribute implementation in a new file `Tactic.ToAdditive.Frontend`, and create an new file `Tactic.ToAdditive` as a placeholder for the `attribute [to_additive]` commands in `Init.ZeroOne`. But if we put these two changes in the same PR, git cannot recognizes that `Tactic.ToAdditive` is renamed, so we split the PR.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
to_additive attribute implementation in a new file Tactic.ToAdditive.Frontend (1/2)to_additive attribute implementation in a new file Tactic.ToAdditive.Frontend (1/2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we want to move the
attribute [to_additive]commands inInit.ZeroOneintoTactic.ToAdditivewithout any other changes.However, the
to_additiveattribute is initialized in the file and cannot be included in the same file.So it would be necessary to isolate the original
to_additiveattribute implementation in a new fileTactic.ToAdditive.Frontend, and create an new fileTactic.ToAdditiveas a placeholder for theattribute [to_additive]commands inInit.ZeroOne.But if we put these two changes in the same PR, git cannot recognizes that
Tactic.ToAdditiveis renamed, so we split the PR.