[Merged by Bors] - chore: speed up by changing def to abbrev in RingTheory/PowerSeries/Basic
#14913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 17bc81bfa6Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
|
!bench |
|
Here are the benchmark results for commit 170f508. Benchmark Metric Change
=============================================================
+ ~Mathlib.RingTheory.PowerSeries.Basic instructions -55.8% |
|
Thanks! bors merge |
|
👎 Rejected by label |
|
Oh sorry, is this really still WIP? |
mattrobball
approved these changes
Jul 19, 2024
|
One change + PR update |
mattrobball
reviewed
Jul 19, 2024
|
Ok two more |
|
bors d+ |
|
✌️ rwst can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
|
👎 Rejected by label |
|
@rwst Can you please take into account the last two comments? Thanks! |
That was my sleepy alter ego, sorry. |
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
…ies/Basic` (#14913) Fixes a 7-10s build delay in `RingTheory/PowerSeries/Basic`, due to `convert` idling, by changing `def` to `abbrev`. Which uncovered a diamond (unwanted `RatFunc.instCoePolynomial`). https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/compiling.20behaviour.20within.20one.20file Co-authored-by: Matthew Ballard <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
def to abbrev in RingTheory/PowerSeries/Basicdef to abbrev in RingTheory/PowerSeries/Basic
judithludwig
pushed a commit
that referenced
this pull request
Jul 20, 2024
…ies/Basic` (#14913) Fixes a 7-10s build delay in `RingTheory/PowerSeries/Basic`, due to `convert` idling, by changing `def` to `abbrev`. Which uncovered a diamond (unwanted `RatFunc.instCoePolynomial`). https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/compiling.20behaviour.20within.20one.20file Co-authored-by: Matthew Ballard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a 7-10s build delay in
RingTheory/PowerSeries/Basic, due toconvertidling, by changingdeftoabbrev. Which uncovered a diamond (unwantedRatFunc.instCoePolynomial).https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/compiling.20behaviour.20within.20one.20file