Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): all morphisms are mono and epi when Quiver.IsThin holds #14936

Closed
wants to merge 3 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Jul 20, 2024

In particular, in preorders, all morphisms are mono and epi.


Open in Gitpod

@joelriou joelriou added t-category-theory Category theory easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 20, 2024
Copy link

github-actions bot commented Jul 20, 2024

PR summary 79b4b6e6d4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : Epi f
+ instance : Mono f

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@erdOne
Copy link
Member

erdOne commented Jul 20, 2024

Can you formulate this using Quiver.IsThin instead?

@riccardobrasca
Copy link
Member

There is a commetn by Andrew, but otherwise LGTM, thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 20, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@joelriou joelriou changed the title feat(CategoryTheory): morphisms in a preorder are all mono and epi feat(CategoryTheory): all morphisms are mono and epi when Quiver.IsThin holds Jul 20, 2024
@joelriou
Copy link
Collaborator Author

Thanks for the suggestion!

@joelriou
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 42fc05c.
There were no significant changes against commit 8f84584.

@joelriou
Copy link
Collaborator Author

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 20, 2024
…in holds (#14936)

In particular, in preorders, all morphisms are mono and epi.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): all morphisms are mono and epi when Quiver.IsThin holds [Merged by Bors] - feat(CategoryTheory): all morphisms are mono and epi when Quiver.IsThin holds Jul 20, 2024
@mathlib-bors mathlib-bors bot closed this Jul 20, 2024
@mathlib-bors mathlib-bors bot deleted the preorder-epi-mono branch July 20, 2024 12:23
judithludwig pushed a commit that referenced this pull request Jul 20, 2024
…in holds (#14936)

In particular, in preorders, all morphisms are mono and epi.
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants