Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove unnecessary imports #14956

Closed
wants to merge 4 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 20, 2024

More import reductions to debug the linter at #14840.


Open in Gitpod

Copy link

github-actions bot commented Jul 20, 2024

PR summary 22492601f9

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Probability.Distributions.Geometric 1700 1248 -452 (-26.59%)
Mathlib.Probability.Distributions.Poisson 1721 1433 -288 (-16.73%)
Import changes for all files
Files Import difference
Mathlib.Probability.Distributions.Geometric -452
Mathlib.Probability.Distributions.Poisson -288

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very nice import reductions!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mattrobball
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 20, 2024
More import reductions to debug the linter at #14840.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove unnecessary imports [Merged by Bors] - chore: remove unnecessary imports Jul 20, 2024
@mathlib-bors mathlib-bors bot closed this Jul 20, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/more_reduced_imports branch July 20, 2024 23:47
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants