-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Order/Floor): x - 1 / 2 < round x
#14964
Conversation
PR summary 5b76afbd63Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
Additionally both theorems should be moved to the |
This pulls in additional imports to a file making basic definitions. Please move to a later or new file. |
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
a - 1 / 2 < round a
x - 1 / 2 < round x
Without |
Alright issue should be fixed. I replaced |
Co-authored-by: Yaël Dillies <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer merge
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Please update the commit message to reflect name changes. Otherwise LGTM. Thanks! P.S.: Also, no need to include proofs in the commit message. It's enough to list lemma names. |
✌️ Colin166 can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Adding a new theorem to Mathlib/Algebra/Order/Floor.lean : ``` theorem round_half_bot : a - (1 / 2 : ℚ) < round a := by rw [round_eq, show (a - 1 / 2 : ℚ) = (a + 1 / 2) - 1 by ring] exact Int.sub_one_lt_floor (a + 1 / 2) ```
Pull request successfully merged into master. Build succeeded: |
x - 1 / 2 < round x
x - 1 / 2 < round x
Adding a new theorem to Mathlib/Algebra/Order/Floor.lean :