[Merged by Bors] - chore: tidy various files #14968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ruben-VandeVelde
commented
Jul 21, 2024
Ruben-VandeVelde
commented
PR summary 16c5bfa04fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
grunweg
reviewed
Jul 21, 2024
| · exact hk | ||
| · rw [← @Nat.le_zero, Nat.not_le] at hk | ||
| rw [choose_zero_pos R hk] | ||
| split_ifs with hk |
| @@ -56,8 +56,10 @@ theorem mem_nonZeroDivisors_of_constantCoeff {φ : MvPowerSeries σ R} | |||
| rw [Finset.sum_eq_single (e,0), coeff_zero_eq_constantCoeff] | |||
| · rintro ⟨u, _⟩ huv _ | |||
| suffices u < e by simp only [he u this, zero_mul, map_zero] | |||
| have hue : u ≤ e := by simp only [← mem_antidiagonal.mp huv, le_add_iff_nonneg_right, zero_le] | |||
| exact ⟨hue, fun h ↦ by simp_all [mem_antidiagonal.mp huv, le_antisymm hue h]⟩ | |||
| apply lt_of_le_of_ne | |||
There was a problem hiding this comment.
I'm not sure if I understand this change: let's have another pair of eyes on it.
There was a problem hiding this comment.
It doesn't introduce a new hypothesis, why not.
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.