Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): the category of commutative squares #14969

Closed
wants to merge 6 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Jul 21, 2024

In this PR, we define a bundled version of CommSq which allows to consider commutative squares as objects in a category Square C.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Jul 21, 2024
Copy link

github-actions bot commented Jul 21, 2024

PR summary 3e211eba44

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Square 272

Declarations diff

+ Hom
+ Square
+ arrowArrowEquivalence
+ arrowArrowEquivalence'
+ category
+ commSq
+ comp
+ flip
+ flipEquivalence
+ flipFunctor
+ fromArrowArrowFunctor
+ fromArrowArrowFunctor'
+ hom_ext
+ id
+ isoMk
+ toArrowArrowFunctor
+ toArrowArrowFunctor'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking about suggesting the same thing when I saw the other PR.
LGTM modulo minor comments.

@joelriou
Copy link
Collaborator Author

Thanks for the reviews @erdOne! Indeed, while finding the better way to formalize Mayer-Vietoris squares, it has become more obvious to me that introducing this category Square C was the better approach.

@erdOne
Copy link
Member

erdOne commented Jul 21, 2024

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 21, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 21, 2024
In this PR, we define a bundled version of `CommSq` which allows to consider commutative squares as objects in a category `Square C`.




Co-authored-by: Joël Riou <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): the category of commutative squares [Merged by Bors] - feat(CategoryTheory): the category of commutative squares Jul 21, 2024
@mathlib-bors mathlib-bors bot closed this Jul 21, 2024
@mathlib-bors mathlib-bors bot deleted the category-theory-square branch July 21, 2024 12:55
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants