[Merged by Bors] - refactor(Tactic/ToAdditive): avoid FindM, got removed in lean4 #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code was using an internal data type from Lean4 that was removed in leanprover/lean4#4795 so let's inline the three lines that we need here.
nomeata
added
the
easy
PR summary 08851066d8Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
grunweg
reviewed
Jul 21, 2024
|
Also, let me add: thanks for taking care of mathlib this way! |
nomeata
added a commit
that referenced
this pull request
Jul 21, 2024
this code was using an internal data type from Lean4 that was removed in leanprover/lean4#4795 so let's inline the three lines that we need here. This is from #14970
grunweg
reviewed
Jul 21, 2024
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 21, 2024
this code was using an internal data type from Lean4 that was removed in leanprover/lean4#4795 so let's inline the three lines that we need here.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this code was using an internal data type from Lean4 that was removed in leanprover/lean4#4795 so let's inline the three lines that we need here.