Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: reduce imports in 14 files under GroupTheory #15004

Closed
wants to merge 1 commit into from

Conversation

rwst
Copy link
Collaborator

@rwst rwst commented Jul 22, 2024

Remove 32 imports from 14 files in GroupTheory, as hinted by #min_imports


Open in Gitpod

@rwst rwst added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 22, 2024
Copy link

PR summary 1015802d9c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@grunweg
Copy link
Collaborator

grunweg commented Jul 22, 2024

These again look like transitive imports, but sure, why not? Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 22, 2024

✌️ rwst can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator

grunweg commented Jul 22, 2024

Thanks!

bors d+

(CI already passes here - if you like, you could also bors merge right away.)

@rwst
Copy link
Collaborator Author

rwst commented Jul 22, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 22, 2024
Remove 32 imports from 14 files in `GroupTheory`, as hinted by `#min_imports`
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: reduce imports in 14 files under GroupTheory [Merged by Bors] - chore: reduce imports in 14 files under GroupTheory Jul 22, 2024
@mathlib-bors mathlib-bors bot closed this Jul 22, 2024
@mathlib-bors mathlib-bors bot deleted the rwst/misc007 branch July 22, 2024 10:51
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants