-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add the cdot
linter
#15010
Conversation
PR summary 7c2a5b94f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great in general! Here's a first round of small comments: I'll eat now, and will return to this afterwards.
Co-authored-by: grunweg <[email protected]>
…unity/mathlib4 into adomani/linter_cdot_only
c452491
to
7c2a5b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this! I just pushed a commit with tiny style-only tweaks directly.
Looks good to me now.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by grunweg. |
bors r+ |
The `cdot` linter is a syntax linter that flags uses of the "cdot" `·` that are achieved by typing a character different from `·`. For instance, a "plain" dot `.` is allowed syntax, but is flagged by the linter. Co-authored-by: Michael Rothgang <[email protected]>
Pull request successfully merged into master. Build succeeded: |
cdot
lintercdot
linter
The
cdot
linter is a syntax linter that flags uses of the "cdot"·
that are achieved by typing a character different from·
.For instance, a "plain" dot
.
is allowed syntax, but is flagged by the linter.