Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add the cdot linter #15010

Closed
wants to merge 6 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 22, 2024

The cdot linter is a syntax linter that flags uses of the "cdot" · that are achieved by typing a character different from ·.

For instance, a "plain" dot . is allowed syntax, but is flagged by the linter.


Open in Gitpod

Copy link

github-actions bot commented Jul 22, 2024

PR summary 7c2a5b94f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cdotLinter
+ findCDot
+ getLinterHash
+ instance : Inhabited Nat
+ isCDot?
+ unwanted_cdot

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in general! Here's a first round of small comments: I'll eat now, and will return to this afterwards.

@grunweg grunweg added the t-linter Linter label Jul 22, 2024
@grunweg grunweg self-assigned this Jul 22, 2024
@grunweg grunweg force-pushed the adomani/linter_cdot_only branch from c452491 to 7c2a5b9 Compare July 22, 2024 14:05
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! I just pushed a commit with tiny style-only tweaks directly.
Looks good to me now.
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@dupuisf
Copy link
Contributor

dupuisf commented Jul 22, 2024

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 22, 2024
The `cdot` linter is a syntax linter that flags uses of the "cdot" `·` that are achieved by typing a character different from `·`.

For instance, a "plain" dot `.` is allowed syntax, but is flagged by the linter.



Co-authored-by: Michael Rothgang <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add the cdot linter [Merged by Bors] - feat: add the cdot linter Jul 22, 2024
@mathlib-bors mathlib-bors bot closed this Jul 22, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/linter_cdot_only branch July 22, 2024 15:26
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-linter Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants