Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Finset): Rename noncommProd_map to map_noncommProd #15048

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Finset): Rename noncommProd_map to map_noncommProd #15048

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jul 23, 2024 •
edited
Loading

This matches the naming of map_multiset_prod

Moves:

  • Multiset.noncommProd_map_aux -> Multiset.map_noncommProd_aux
  • Multiset.noncommSum_map_aux -> Multiset.map_noncommSum_aux
  • Multiset.noncommProd_map -> Multiset.map_noncommProd
  • Multiset.noncommSum_map -> Multiset.map_noncommSum
  • Finset.noncommProd_map -> Finset.map_noncommProd
  • Finset.noncommSum_map -> Finset.map_noncommSum

Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

PR summary f7a90e5e00

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ map_noncommProd_aux
+ noncommSum_map_aux
++ map_noncommProd
++ noncommSum_map
++-- noncommProd_map

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@YaelDillies YaelDillies mentioned this pull request Jul 23, 2024
Closed
eric-wieser
eric-wieser approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Please also deprecate and list the additive variants.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 23, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies
Copy link
Collaborator Author

Done

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 23, 2024
@YaelDillies
chore(Finset): Rename noncommProd_map to map_noncommProd (#15048)
cdc5e65 
This matches the naming of `map_multiset_prod`

Moves:
- Multiset.noncommProd_map_aux -> Multiset.map_noncommProd_aux
- Multiset.noncommSum_map_aux -> Multiset.map_noncommSum_aux
- Multiset.noncommProd_map -> Multiset.map_noncommProd
- Multiset.noncommSum_map -> Multiset.map_noncommSum
- Finset.noncommProd_map -> Finset.map_noncommProd
- Finset.noncommSum_map -> Finset.map_noncommSum
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Finset): Rename noncommProd_map to map_noncommProd [Merged by Bors] - chore(Finset): Rename noncommProd_map to map_noncommProd Jul 23, 2024
@mathlib-bors mathlib-bors bot closed this Jul 23, 2024
@mathlib-bors mathlib-bors bot deleted the map_noncomm_prod branch July 23, 2024 13:52
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaelDillies @eric-wieser @leanprover-community-mathlib4-bot