Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ZMod): Simple lemmas #15076

Closed
wants to merge 2 commits into from
Closed

Conversation

YaelDillies
Copy link
Collaborator

From LeanAPAP


Open in Gitpod

@YaelDillies YaelDillies added the t-algebra Algebra (groups, rings, fields, etc) label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

PR summary 8ad733242f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ intCast_cast_add
+ intCast_cast_mul
+ intCast_cast_neg
+ intCast_cast_sub
+ inv_one
+ lift_injective
+ mul_val_inv
+ nsmul_zmod_val_inv_nsmul
+ pow_pow_zmod_val_inv
+ pow_zmod_val_inv_pow
+ val_inv_mul
+ val_one''
+ zmod_val_inv_nsmul_nsmul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

section Group
variable {α : Type*} [Group α] {n : ℕ}

--TODO: Fix additivisation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sadly to_additive chokes on Inv (ZMod n). cc @fpvandoorn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, maybe add a (very) short explanation that this is the problem (of course if you want to add and issue and link it here even better...).

@riccardobrasca
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 24, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 24, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(ZMod): Simple lemmas [Merged by Bors] - feat(ZMod): Simple lemmas Jul 24, 2024
@mathlib-bors mathlib-bors bot closed this Jul 24, 2024
@mathlib-bors mathlib-bors bot deleted the zmod_inv_one branch July 24, 2024 14:53
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants