Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: protect congr_arg's and congr_fun's #15083

Closed
wants to merge 3 commits into from

Conversation

mattrobball
Copy link
Collaborator

We already have congr_arg and congr_fun in the root namespace.


Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 23, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up! All these theorems are already namespaced, but protecting them probably doesn't hurt.
Feel free to maintainer merge on my behalf once you have fixed the merge conflicts.

Copy link

PR summary bec3ebb160

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 24, 2024
@grunweg
Copy link
Collaborator

grunweg commented Jul 24, 2024

Given CI passes, let me
maintainer merge
myself.

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@kim-em
Copy link
Contributor

kim-em commented Jul 24, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 24, 2024
We already have `congr_arg` and `congr_fun` in the root namespace.



Co-authored-by: Matthew Robert Ballard <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: protect congr_arg's and congr_fun's [Merged by Bors] - chore: protect congr_arg's and congr_fun's Jul 25, 2024
@mathlib-bors mathlib-bors bot closed this Jul 25, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/protect_ringhom_congr_arg branch July 25, 2024 00:13
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants