Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: deprecate sizeOf_dropSlice_lt #15118

Closed
wants to merge 1 commit into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jul 25, 2024

As far as I can tell this lemma is not used anywhere. If it were needed somewhere, it would be better to proceed via Sublist in any case.

As a consolation prize I've added the simpler lemma length_dropSlice.

@kim-em kim-em changed the title chore: deprecate sizeOf_dropSlice_lt chore: deprecate sizeOf_dropSlice_lt Jul 25, 2024
Copy link

PR summary fe7524ba99

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ length_dropSlice
+ length_dropSlice_lt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that using length makes much more sense for Lists (but I'm not an expert on this part of the library). Let's have some more eyes on this:
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 25, 2024
As far as I can tell this lemma is not used anywhere. If it were needed somewhere, it would be better to proceed via `Sublist` in any case.

As a consolation prize I've added the simpler lemma `length_dropSlice`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deprecate sizeOf_dropSlice_lt [Merged by Bors] - chore: deprecate sizeOf_dropSlice_lt Jul 25, 2024
@mathlib-bors mathlib-bors bot closed this Jul 25, 2024
@mathlib-bors mathlib-bors bot deleted the deprecate_sizeOf_dropSlice_lt branch July 25, 2024 08:40
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants